reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Putting all adapters in their own repositories #47

Closed WyriHaximus closed 5 years ago

WyriHaximus commented 5 years ago

One of the things I have been thinking about for v0.2 is pulling all adapters out of this repository and putting them child process one under reactphp and others either under reactphp and/or friends-of-reactphp.

Pros:

Cons:

What are your opinions about this @clue, @jsor, and @cboden?

clue commented 5 years ago

My vote is: batteries included, but swappable.

It's my understanding that this project should fulfill the 80% use case without requiring any additional repositories. For people that have special requirements, they can still rely on the interfaces exposed and use a custom/special implementation. This is in line with how the EventLoop component provides implementations for common extensions and still allows consumers to use experimental extensions by implementing the LoopInterface themselves.

Unlike the Cache component, I don't see us ever ending up with dozens of possible implementations. Should this turn out to happen in the future, we can still do a split then.

jsor commented 5 years ago

What @clue said 👍

WyriHaximus commented 5 years ago

Agreed 👍