search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Change promise usage to recommendation #49

Closed ghost closed 5 years ago

ghost commented 5 years ago

This PR is a split of the original PR #45 (the original PR shall stay open until completely done).

This PR changes the usage of promises inside this library to the recommendation listed on reactphp/promise. This PR also removes the unreachable code in AbstractSyncAdapter and adds exceptions to rejected promises.

The used promises in the tests are untouched, as they will be refactored anyway in a future PR.

jsor commented 5 years ago

I'm not able to approve through the UI currently due to unicorns. So, oldschool :shipit: for now.

jsor commented 5 years ago

I'm not able to approve through the UI currently due to unicorns. So, oldschool :shipit: for now.