Resolve with array instead of SplObjectStorage (AdapterInterface::ls(), Node\DirectoryInterface::lsRecursive(), Node\NodeInterface::copy, ObjectStreamSink::promise())

reactphp / filesystem

Evented filesystem access.

MIT License

135 stars 38 forks source link

Resolve with array instead of SplObjectStorage (AdapterInterface::ls(), Node\DirectoryInterface::lsRecursive(), Node\NodeInterface::copy, ObjectStreamSink::promise()) #58

Closed ghost closed 5 years ago

ghost commented 5 years ago

As discussed in the comments of #57 - this PR changes ObjectStreamSink::promise to resolve with an array, instead of an unexpected SplObjectStorage.

ghost commented 5 years ago

Affected by this change are the following methods:

AdapterInterface::ls (needs to be upgraded by users due to promises anyway)
Node\NodeInterface::copy (Directory, File and Link node instances)
Node\DirectoryInterface::lsRecursive (Directory node instances)