search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Use Adapter *Contents instead in File Node #80

Closed ghost closed 4 years ago

ghost commented 4 years ago

This patch updates Node/File to use the methods on the AdapterInterface instead of open the file for reading or writing and buffer the stream.

Fixes #63.

ghost commented 4 years ago

@WyriHaximus Please restart the CI build. However the Directory Test failures are unrelated to this PR.

WyriHaximus commented 4 years ago

@CharlotteDunois will kick them for a while, need to finish #78 to resolve this

WyriHaximus commented 4 years ago

@CharlotteDunois all failing tests look EIO related to me

ghost commented 4 years ago

@clue This is already covered by the Adapters/FileTest.php test suite. Unless you mean overwriting an existing file, that would need an additional test.