reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Rewrite #97

Closed WyriHaximus closed 2 years ago

WyriHaximus commented 2 years ago

This is a full rewrite of this package including the following features/changes:

This PR doesn't include the following features/changes as those will be added in with followup PR's:

cc: @SimonFrings

WyriHaximus commented 2 years ago

@clue @SimonFrings This PR is now fully ready for review. The green build can be found here. And a readable render of the readme here.

WyriHaximus commented 2 years ago

@SimonFrings Thanks! Just updated this PR with your suggestions :+1:

WyriHaximus commented 2 years ago

@clue :ship: :it: !

I agree with everything that's been said, so I only briefly eyeballed this. This may not be perfect (yet), but it's definitely a major improvement over the current experimental filesystem implementation. Let's get this in as-is and build on top of this with future PRs +1

Already on it! https://github.com/reactphp/filesystem/pull/99