search

reactphp / filesystem

Evented filesystem access.
MIT License
135 stars 40 forks source link

Fix php8.1 deprecation error #98

Closed asika32764 closed 1 year ago

asika32764 commented 2 years ago

The error was caused by https://github.com/WyriHaximus/reactphp-child-process-messenger/blob/master/src/ChildInterface.php#L11

Must change return type to mixed

WyriHaximus commented 2 years ago

This might not be invalid after all, does the error you mention at https://github.com/WyriHaximus/reactphp-child-process-messenger/pull/79#issue-839954256 disappear when you add this line?

asika32764 commented 2 years ago

#[\ReturnTypeWillChange] won't work, must remove void from the interface return type.

WyriHaximus commented 2 years ago

#[\ReturnTypeWillChange] won't work, must remove void from the interface return type.

It is not there for the latest tagged version: https://github.com/WyriHaximus/reactphp-child-process-messenger/blob/4.0.2/src/ChildInterface.php#L16

asika32764 commented 1 year ago

Close since the root library updated.