search

reactphp / http

Event-driven, streaming HTTP client and server implementation for ReactPHP.
https://reactphp.org/http/
MIT License
744 stars 143 forks source link

Enable HTTP keep-alive by default for HTTP client #495

Closed clue closed 1 year ago

clue commented 1 year ago

This changeset enables HTTP keep-alive by default for the HTTP client. HTTP keep-alive (reusing persistent connections) offers significant performance improvements when sending many requests to the same host as it avoids recreating the underlying TCP/IP connection and repeating the TLS handshake for secure HTTPS requests.

HTTP keep-alive is now enabled by default. If you do not want to use HTTP keep-alive, you can disable this feature by sending a Connection: close HTTP request header or by using HTTP/1.0 like this:

// not recommended: add `Connection: close` request header to disable HTTP keep-alive
$browser = $browser->withHeader('Connection', 'close');

// not recommended: use HTTP/1.0 to disable HTTP keep-alive
$browser = $browser->withProtocolVersion('1.0');

We've done some careful testing in PR #486 and our sophisticated test suite that covers tests against both well-behaving and misbehaving HTTP servers that might occur in the wild. On top of this, we've done some extensive tests in real-world applications in the past weeks after merging this feature. The test suite confirms this has 100% code coverage and does not otherwise affect our public APIs. If you encounter any issues with this in the wild, please confirm by disabling HTTP keep-alive and report a bug ticket in this case. If you'd like to support this development, consider sponsoring ReactPHP! ❤️

Builds on top of #486, #484 and others Refs #488, #468 and others

WyriHaximus commented 1 year ago

:rocket: :rocket: :rocket: :rocket: :rocket: !