search

reactphp / http

Event-driven, streaming HTTP client and server implementation for ReactPHP.
https://reactphp.org/http/
MIT License
747 stars 143 forks source link

fix: #504 laravel + websockets: Unhandled promise rejection with TypeError #506

Closed SocolaDaiCa closed 8 months ago

SocolaDaiCa commented 1 year ago

504

SimonFrings commented 8 months ago

@SocolaDaiCa thanks for trying to fix the issue reported in #504 :+1:

I just gave an explanation in #504 why this isn't really a bug in our HTTP component and should be reported downstream in https://github.com/beyondcode/laravel-websockets instead.

I can totally understand the reason behind this pull request, as it makes sense that we should support Throwables instead of just exceptions. Raising the PHP version from PHP 5.3 to PHP 7 is at least a BC break and I don't think we want to go this step for the current v1.

We're currently working on ReactPHP v3 which will raise the minimal supported PHP version to PHP 7.1 anyway, so I think we might want to take a look at this over there. We also have plans to improve the error reporting for v3, so I think we will pick this up in the upcoming weeks/months. The v3 roadmap ticket for HTTP is still outstanding but will drop soon.

With all that said, I'll close this ticket for now and we'll have a look at this as we move forward with ReactPHP v3 :rocket: