search

reactphp / http

Event-driven, streaming HTTP client and server implementation for ReactPHP.
https://reactphp.org/http/
MIT License
747 stars 143 forks source link

Can't find ringcentral/psr7 #531

Closed enterlight closed 5 months ago

enterlight commented 5 months ago

Since today 06/11/2024 @ 5PM ET our pipelines are failing with unable to build dependencies. Apparently https://github.com/ringcentral/psr7 no longer exist... It's listed as a dependency.

  Failed to execute git clone --no-checkout -- 'https://ghp...ge0:x-oauth-basic@github.com/ringcentral/psr7.git' '/var/www/he-deploy/vendor/ringcentral/psr7' && cd '/var/www/he-deplo  
  y/vendor/ringcentral/psr7' && git remote add composer -- 'https://ghp...ge0:x-oauth-basic@github.com/ringcentral/psr7.git' && git fetch composer && git remote set-url origin -- 'ht  
  tps://github.com/ringcentral/psr7.git' && git remote set-url composer -- 'https://github.com/ringcentral/psr7.git'                                                                    

  Cloning into '/var/www/he-deploy/vendor/ringcentral/psr7'...                                                                                                                          
  remote: Repository not found.                                                                                                                                                         
  fatal: repository 'https://github.com/ringcentral/psr7.git/' not found
image
lucasnetau commented 5 months ago

The current version 1.10 of reactphp/http does not have this dependance, however the dev dependancy clue/reactphp-http-proxy still has this dependancy, Issue raised: https://github.com/clue/reactphp-http-proxy/issues/58

composer --no-dev works fine for install.

SimonFrings commented 5 months ago

What @lucasnetau says, we removed the dependency on https://github.com/ringcentral/psr7 in #522 and are now using our own PSR-7 implementation for ReactPHP. You could either target an older version (like v1.9.0) or you can use our v1.10.0 and explicitly add ringcentral/psr7 as a dependency. Hope this helps :+1:

I believe this should answer this ticket, so I will close it for now. We can reopen this if you encounter the same problem after trying out the suggested changes.

lucasnetau commented 5 months ago

@SimonFrings no exactly. The dependency is still there if you install this packing with dev dependencies which most developers would do due to the linked package.

SimonFrings commented 5 months ago

@lucasnetau True, this comes through installing the https://github.com/clue/reactphp-http-proxy, but like I said in https://github.com/clue/reactphp-http-proxy/issues/58#issuecomment-2162255993, the reingcentral/psr7 dependency will probably be removed in the future there as well. Once this happens and a new release for reactphp-http-proxy gets shipped, this would break installation again. In my opinion it's better to install this component explicitly if you rely on it in order to avoid this happening again.