Fix expected error code in tests when ext-sockets is not enabled

reactphp / http

Event-driven, streaming HTTP client and server implementation for ReactPHP.

https://reactphp.org/http/

MIT License

747 stars 143 forks source link

Fix expected error code in tests when ext-sockets is not enabled #532

Closed lucasnetau closed 2 months ago

lucasnetau commented 5 months ago

The expected error code when ext-sockets is not enabled (SOCKET_EMSGSIZE is not defined) is 90 per the two places that OverFlowException is created in class Transaction

https://github.com/reactphp/http/blob/212382c3559fa1a40fb1598b4cb92f3c97f7232e/src/Io/Transaction.php#L173-L176 https://github.com/reactphp/http/blob/212382c3559fa1a40fb1598b4cb92f3c97f7232e/src/Io/Transaction.php#L205-L208

SimonFrings commented 5 months ago

@lucasnetau Thanks for bringing this up :+1:

Seems like a reasonable change to me, but I don't have at much insights on this as @clue and @WyriHaximus, so interested in their opinion on this.

WyriHaximus commented 2 months ago

Once merged, we should probably backport the same changes to the 1.x branch as well 👍

Just filed #539 to address this in the 1.x branch.