search

reactphp / promise

Promises/A implementation for PHP.
https://reactphp.org/promise/
MIT License
2.39k stars 147 forks source link

Cancellable promises. #14

Closed jmalloc closed 10 years ago

jmalloc commented 10 years ago

Hey guys, I noticed that there's an implementation of cancellable promises in a branch. Is that something that is desired in v2? Are there any hurdles that need to be overcome?

jsor commented 10 years ago

IIRC i was unsure how to propagate through the promise chain plus i wanted to wait until there is a spec finalized: https://github.com/promises-aplus/cancellation-spec/issues

jmalloc commented 10 years ago

I read the whole of "Draft C" without even realising it was a draft >_< Makes sense, thanks :)

clue commented 10 years ago

Just for the reference: This feature has been implemented with #20 which landed in the recent v2.1.0 release.