Closed Gert-dev closed 4 years ago
I didn't consider that, but you are right; it is a subtle BC break.
I see that you indeed added PromiseInterface
on the master
branch and the ExtendedPromiseInterface
doesn't appear to exist anymore, so this becomes a nonissue there. I'll close this pull request in that case, thanks!
The interface indicates it returns a
PromiseInterface
, but the implementation returns aPromise
, which also implementsExtendedPromiseInterface
.Calling
Deferred::promise()
will make PHPStan complain if you need to return anExtendedPromiseInterface
, as it cannot deduce that it does indeed return it from the implementation alone.This should also aid autocompletion in IDEs.