search

reactphp / promise

Promises/A implementation for PHP.
https://reactphp.org/promise/
MIT License
2.38k stars 146 forks source link

Reduced promises depth test #193

Closed woodongwong closed 3 years ago

woodongwong commented 3 years ago

When I execute phpunit, it prompts me Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes), which I know I can fix by modifying php.ini. I think I can reduce the promises depth, i.e. I can not modify the memory_limit (default 128M) and also ensure the correct test, thanks. (very sorry, English is not my native language)

SimonFrings commented 3 years ago

@woodongwong thanks for looking into this :+1: You're right with the memory_limit being 128M by default, so i don't see any reason to reject your changes.

For now you can raise your memory_limit by executing the test suite like this:

$ php -d memory_limit=256M vendor/bin/phpunit

@clue @WyriHaximus what do you think about this?