search

reactphp / promise

Promises/A implementation for PHP.
https://reactphp.org/promise/
MIT License
2.38k stars 146 forks source link

Support intersection types (PHP 8.1+ / ported from v2 to v3) #209

Closed bzikarsky closed 2 years ago

bzikarsky commented 2 years ago

See #195 for details.

Unrelated: I fixed an E_DEPRECATED on 8.1 in RejectedPromiseTest (Deprecated: Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated in /code/tests/Internal/RejectedPromiseTest.php on line 40) - Are you fine with adding this in an additional commit to the PR or do you want to have a separate PR (and more rebase action)?

clue commented 2 years ago

Unrelated: I fixed an E_DEPRECATED on 8.1 in RejectedPromiseTest (Deprecated: Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated in /code/tests/Internal/RejectedPromiseTest.php on line 40) - Are you fine with adding this in an additional commit to the PR or do you want to have a separate PR (and more rebase action)?

@bzikarsky I can indeed see the same error on PHP 8.1 (#199) and you're right that this seems to be unrelated to this PR, so perhaps better file this as a separate PR? :shipit:

bzikarsky commented 2 years ago

Thanks @clue for going over it.

Those 7.1 related simplifications make sense and I can also supply that extra fix in a separate PR. It may have to wait until Monday though - depending on what my family is up to over the weekend. 🙂

bzikarsky commented 2 years ago

Improvements are in. :slightly_smiling_face:

Unrelated: I fixed an E_DEPRECATED on 8.1 in RejectedPromiseTest (Deprecated: Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated in /code/tests/Internal/RejectedPromiseTest.php on line 40) - Are you fine with adding this in an additional commit to the PR or do you want to have a separate PR (and more rebase action)?

@bzikarsky I can indeed see the same error on PHP 8.1 (#199) and you're right that this seems to be unrelated to this PR, so perhaps better file this as a separate PR? :shipit:

PR is at https://github.com/reactphp/promise/pull/210.