reactphp / promise

Promises/A implementation for PHP.
https://reactphp.org/promise/
MIT License
2.38k stars 146 forks source link

[WIP][2.x] Add template annotations #223

Open WyriHaximus opened 2 years ago

WyriHaximus commented 2 years ago

FYI just filed https://github.com/reactphp/promise/pull/227 and https://github.com/reactphp/promise/pull/228

Both are a getting support out there and then improve on it kind of PR.

zmitic commented 1 year ago

Sorry for barging but I am really interested in this PR and would like to remove my own stubs. Should I wait for merge or use PR branch instead?

WyriHaximus commented 1 year ago

@zmitic Honestly same, will have a look at this again during the weekend and hopefully, this got resolved in recent PHPStan updates. But currently support for mixed scalar and scalar through PromiseInterface is blocking this

WyriHaximus commented 1 year ago

Opened https://github.com/phpstan/phpstan/issues/8707 to hopefully get the last few functions fully in

WyriHaximus commented 1 year ago

PR's to address our current template param buggy use can be found here: