search

reactphp / promise

Promises/A implementation for PHP.
https://reactphp.org/promise/
MIT License
2.38k stars 146 forks source link

Add PHP 8.4 to the CI and fix implicit nullable types #259

Closed nicolas-grekas closed 5 months ago

nicolas-grekas commented 7 months ago

Cherry-picking from #258

nicolas-grekas commented 7 months ago

(I'm now looking at why the job fails on 8.4)

nicolas-grekas commented 7 months ago

Now green on PHP 8.4. All it needs is the latest version of phpunit (not tagged yet)

Seldaek commented 6 months ago

Great, thanks for listening to feedback :)

andypost commented 5 months ago

Is there any expected date for new release compatible with fixed nullable types? PHPstan depends on it and it will be helpful to prevent this deprecations

SimonFrings commented 5 months ago

I opened a new pull request in #260 for this. The ongoing development in PHP 8.4 is currently breaking our test suite (changed stack trace -> failing .phpt test files), which will be visible in here once we'd rerun the currently green test suite (last executed on 2024-03-19).

I created a new proposal, which follows the original pull request from @Ayesh in #258. I tried to reopen the old PR, but couldn't do so as the created fork was already removed. Once #260 is approved and merged, it will automatically close this PR here as well.

Sorry for the back and forth, but I think we've come to a viable solution now. Thanks for everybody who contributed to the discussion :+1: