Fix cancelling happy eyeballs to stop timer, fix rejection reason and simplify timer logic

reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.

https://reactphp.org/socket/

MIT License

1.2k stars 156 forks source link

Fix cancelling happy eyeballs to stop timer, fix rejection reason and simplify timer logic #225

Closed clue closed 4 years ago

clue commented 4 years ago

This changeset fixes a leftover timer reference when cancelling the happy eyeballs connection attempt. Additionally, this increases test coverage to 100% and significantly improves test times (27s->5s).

Builds on top of #224