search

reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.21k stars 157 forks source link

Support falling back to multiple DNS servers from DNS config #257

Closed clue closed 3 years ago

clue commented 3 years ago

This changeset adds support for falling back to multiple DNS servers from DNS config. In other words, if you have multiple DNS servers configured (rare) and connectivity to the primary DNS server is broken (even rarer), it will now fall back to your other DNS servers.

This is done by simply passing the complete list of DNS servers down to the DNS component that is responsible for setting up the DNS executor stack. Accordingly, this builds on top of https://github.com/reactphp/dns/pull/179 and https://github.com/reactphp/dns/pull/180.

clue commented 3 years ago

The first commit updates this to the currently unreleased DNS component to show how this feature is used in this component (the build should be green). The second commit updates this to the release that has yet to be tagged. This is expected to fail at the moment and should be green once the release is tagged and the build is restarted.

This is ready for review. I will restart the build and merge once reviewed and the DNS component is tagged.

clue commented 3 years ago

Restarted build and everyhing's green now that reactphp/dns v1.7.0 has been released :shipit: