reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.2k stars 156 forks source link

Avoid dependency on `ext-filter` #279

Closed clue closed 2 years ago

clue commented 2 years ago

This simple changeset avoids an unneeded (and undeclared!) dependency on ext-filter. The extension is enabled by default, but can explicitly be disabled with --without-filter.

The code in question is already covered by the test suite, so the test suite confirms this changeset does not affect behavior or our public API in any way. Accordingly, this is entirely transparent for all consumers of this package, plus now also supports consumers that happen to use --without-filter.

The changes have been ported from https://github.com/reactphp/dns/pull/185 See https://www.php.net/manual/en/filter.installation.php Originally reported in https://github.com/leproxy/leproxy/issues/80 Refs https://github.com/reactphp/socket/pull/17