search

reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.2k stars 156 forks source link

Update test suite to future-proof base images #299

Closed clue closed 1 year ago

clue commented 1 year ago

This simple changeset updates the test suite to future-proof base images. Likewise, legacy HHVM is now executed in an up-to-date base image, but using a legacy container instead. This way, we no longer depend on any legacy base images that will be removed in the future as per https://github.blog/changelog/2022-08-09-github-actions-ubuntu-22-04-is-now-generally-available-on-github-hosted-runners/, https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/ and https://github.com/actions/runner-images/issues/6002. I've confirmed pulling container images from Docker Hub does not appear to be rate-limited as per https://github.com/actions/runner-images/issues/1445. Once these changes are merged, we should apply similar updates to all our other components.

Builds on top of #297 and #289

clue commented 1 year ago

Updated to work around failing test case for legacy HHVM (trying to allocate 1048576 file descriptors turns out to be a bad idea). This is now ready for review :shipit:

clue commented 1 year ago

I've just updated this to use actions/checkout@v3 instead of v1 and only use the legacy HHVM container to run Composer and PHPUnit (also refs https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). This is now ready for review (again) :shipit: