search

reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.2k stars 156 forks source link

Update test environment to report failed assertions #300

Closed clue closed 1 year ago

clue commented 1 year ago

Builds on top of #299 and https://github.com/clue/framework-x/pull/199 Refs https://github.com/shivammathur/setup-php/issues/582 and https://github.com/shivammathur/setup-php/issues/450

clue commented 1 year ago

I've updated this to work around a super nasty bug in reactphp/async v4. Until this is fixed upstream (see https://github.com/reactphp/async/pull/65), the work around already allows us to merge this as is. This work around can be removed again once fixed upstream, but it should not cause any issues in either case. Together with the changes upstream, you're looking at ~6h of work to achieve what should have been pretty much only a configuration change, enjoy! This is now ready for review. :shipit: