search

reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.2k stars 156 forks source link

Include timeout logic to avoid dependency on reactphp/promise-timer #305

Closed clue closed 1 year ago

clue commented 1 year ago

This changeset adds timeout logic to avoid the otherwise unneeded dependency on reactphp/promise-timer. There are plans to deprecate the reactphp/promise-stream package as discussed in https://github.com/orgs/reactphp/discussions/475 and in either case I'd like to remove additional dependencies where possible.

In particular, reactphp/socket appears to be the only ReactPHP packages that still depends on reactphp/promise-timer at the moment. This means that once this PR is merged, most consumers of this package would no longer install reactphp/promise-timer by default. Perhaps most notably, this means that IDE autocompletion for resolve() and reject() would now only suggest the correct React\Promise\resolve() and React\Promise\reject() functions instead of the rarely useful and deprecated ones (see https://github.com/reactphp/promise-timer/pull/51).

This changeset does not otherwise affect our public API, so this should be safe to apply. The test suite confirms this has 100% code coverage and does not otherwise affect our APIs.

Note that this changeset does not preclude the discussion in https://github.com/orgs/reactphp/discussions/475, so whether or not or when the package will be deprecated is still up for debate. If you want to explicitly install this dependency, you can still install it like this:

composer require react/promise-timer

Builds on top of https://github.com/reactphp/dns/pull/213 and others See also https://github.com/reactphp/http/pull/482 for similar changes to remove reactphp/promise-stream from reactphp/http

clue commented 1 year ago

Note the build error on legacy PHP 5.4 on Windows is unrelated to this changeset, see #306 for workaround. We can either proceed with applying this PR with a known build error or merge the other PR first and rebase this one, either works for me 👍

WyriHaximus commented 1 year ago

Note the build error on legacy PHP 5.4 on Windows is unrelated to this changeset, see #306 for workaround. We can either proceed with applying this PR with a known build error or merge the other PR first and rebase this one, either works for me +1

That error just blows my mind. But approved and merged it.