This simple changeset drops the deprecated alternative Connector constructor argument order. As of v1.9.0, we recommend using the new Connector signature with the optional $context as first argument and optional $loop as second argument, so upgrading should be straightforward for most use cases:
// unchanged
$connector = new React\Socket\Connector();
// old (no longer supported)
$connector = new React\Socket\Connector(null, $context);
$connector = new React\Socket\Connector($loop, $context);
// new (already supported since v1.9.0)
$connector = new React\Socket\Connector($context);
$connector = new React\Socket\Connector($context, $loop);
The original deprecation message has been in place for a couple of years already, so this should be relatively safe to apply.
Note that this temporarily introduces an implicitly nullable type that should be removed in a follow-up as discussed in https://github.com/reactphp/promise/pull/260. Additionally, a follow-up PR should drop the entire $loop argument as discussed in #312.
This simple changeset drops the deprecated alternative
Connectorconstructor argument order. As ofv1.9.0, we recommend using the newConnectorsignature with the optional$contextas first argument and optional$loopas second argument, so upgrading should be straightforward for most use cases:The original deprecation message has been in place for a couple of years already, so this should be relatively safe to apply.
Note that this temporarily introduces an implicitly nullable type that should be removed in a follow-up as discussed in https://github.com/reactphp/promise/pull/260. Additionally, a follow-up PR should drop the entire
$loopargument as discussed in #312.Builds on top of #264 and #314.