reactphp / socket

Async, streaming plaintext TCP/IP and secure TLS socket server and client connections for ReactPHP.
https://reactphp.org/socket/
MIT License
1.2k stars 156 forks source link

[3.x] Improve PHP 8.4+ support by avoiding implicitly nullable types #317

Closed clue closed 1 month ago

clue commented 2 months ago

This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in https://github.com/reactphp/promise/pull/260.

I'm planning to add native types to the public API and introduce PHPStan in follow-up PRs.

Once merged, we should apply similar changes to all our upcoming v3 components. On top of this, we should backport similar changes to the v1 branch.

Builds on top of #316, #315, #310, #260, reactphp/promise#260, https://github.com/reactphp/dns/pull/224, https://github.com/reactphp/stream/pull/179, reactphp/async#87 and reactphp/promise-timer#70