reactplay / react-play

react-play is an opensource platform that helps you learn ReactJS faster with hands-on practice model. It is a collection of projects that you can use to learn ReactJS.
https://reactplay.io
MIT License
1.37k stars 841 forks source link

✨ [Feature request]: Add Testimonial Button #1523

Open Shivam-Katare opened 1 month ago

Shivam-Katare commented 1 month ago

Is your feature request related to a problem? Please describe.

There should be an option to add a testimonial directly from here, instead of clicking on the View All button and then adding it. Having the option here along with View All would be more convenient.

image

Describe the solution you'd like.

There should be a button or link for submitting a testimonial directly on the same page where the testimonials are displayed. This button could be placed next to or below the "View All" button. Users would be able to add a testimonial without navigating to a separate page.

Describe alternatives you've considered.

On the same page, we can add a Modal for Testimonials. Instead of redirecting to a different page, a modal could pop up when users click "Add Testimonial." This would allow users to add their feedback without leaving the current page.

Screenshot / Screenshare

No response

Additional context

No response

Record

Code of Conduct

github-actions[bot] commented 1 month ago

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Adil-Khan-N commented 1 month ago

Could you please assign this issue to me?

priyankarpal commented 1 month ago

Could you please assign this issue to me?

Unfortunately, you can only work one issue at a time,so other contributors can work.

day-lee commented 1 month ago

Can I work on this?

Abhishek-90 commented 1 month ago

Assigning to you @day-lee, Happy Coding!

KrishDave1 commented 1 month ago

This issue has not been resolved till now.Can I work on this issue?

day-lee commented 1 month ago

@KrishDave1 Hi, I am currently working on it locally.

PriteshKiri commented 1 month ago

Hey @day-lee ,

Any updates on the issue?

day-lee commented 1 month ago

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem. When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please? Thanks,

image

nilaygit-10721 commented 1 week ago

This issue has not been resolved till now.Can I work on this issue?

PriteshKiri commented 1 week ago

@Shivam-Katare @Sachin-chaurasiya can you please check the suggestion by @day-lee ?

PriteshKiri commented 1 week ago

@nilaygit-10721 the issue is under discussion. Can you please checkout other issues?

Sachin-chaurasiya commented 1 week ago

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem. When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please? Thanks,

image

Hey @day-lee, in order to add a testimonial, users need to authenticate via GitHub. When they click the +Testimonial button, we retrieve the user token from Nhost and then display the add testimonial page. However, I noticed that the URL https://auth.nhost.run/v1/token is failing, which is why the add testimonial page isn't rendering properly. cc: @priyankarpal can you check why https://auth.nhost.run/v1/token is failing on production?