reactplay / react-play

react-play is an opensource platform that helps you learn ReactJS faster with hands-on practice model. It is a collection of projects that you can use to learn ReactJS.

https://reactplay.io

MIT License

1.36k stars 843 forks source link

Feature/play/zoomlogin refactor1 #1554

Closed day-lee closed 1 month ago

day-lee commented 1 month ago

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Chatbot option buttons have either hover:cursor-pointer or hover:cursor-not-allowed depending on the feature development. "My Account is Locked" is developed but stated as not allowed, hence changed the cursor accordingly.
removed unused file
refactor label htmlFor to match the input id

Fixes #1555

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manual test

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

not-allowed cursor is shown pointer cursor should be displayed

netlify[bot] commented 1 month ago

Deploy Preview for reactplayio ready!

Name	Link
Latest commit	37376e6db4e94ef69dea74515075b8bcf0f78f9f
Latest deploy log	https://app.netlify.com/sites/reactplayio/deploys/670fdfaff3f6740008c2a991
Deploy Preview	https://deploy-preview-1554--reactplayio.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.