search

reactrondev / react-native-web-swiper

Swiper-Slider for React-Native and React-Native-Web
213 stars 55 forks source link

Fix: DotComponent typing #59

Closed kopax closed 3 years ago

kopax commented 3 years ago

Fix https://github.com/reactrondev/react-native-web-swiper/issues/56

kopax commented 3 years ago

I am not a TS expert but I think this type is for both FunctionComponent and ClassComponent, as per this comment : https://stackoverflow.com/a/60389552/2127277

jarvisluong commented 3 years ago

We can even go extra mile by specifying which props are supported with the dot component by providing a generic param to the ComponentType. However, this is mostly okay for now.

kopax commented 3 years ago

Thank you, would you mind releasing for us? I checked travis but the project is not on it.