Open thetric opened 5 years ago
The Modal
component uses deprecated lifecycle hooks:
componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Modal
componentWillUpdate: Please update the following components to use componentDidUpdate instead: Modal
I'll submit a PR for it!
Duplicate of https://github.com/reactstrap/reactstrap/issues/1159
@gergely-nagy any progress?
Same thing on Collapse
:
I got this warning with Tooltip
, if that helps.
I got this warning with Carousel.
Anyone interested in fixing this? Here Is a starting point https://github.com/reactstrap/reactstrap/pull/1866 One test is failing. I can't alocate more time.
I got this warning with Tooltip
Also happening in Fade component
I got this warning with Collapse navbar.
Got this warning in
in Transition (created by Collapse) in Collapse (at AppNavbar.js:24) in div (created by Container) in Container (at AppNavbar.js:21) in nav (created by Navbar) in Navbar (at AppNavbar.js:20) in div (at AppNavbar.js:19) in AppNavbar (at App.js:10) in div (at App.js:9) in App (at src/index.js:8) in StrictMode (at src/index.js:7)
Carousel
right now, no other places.react-transition-group
, if you enable StrictMode
, because it uses deprecated findDOMNode
APISame thing on
Collapse
:
Even I get similar warning, is there a work around or fix for this?
Workaround: Remove strictMode from index.js
It is not resolved yet
@xreider do you want to help fixing it?
In index.js change React.StrictMode
toReact.Fragment
@@
Alert is causing this issue for me
switch to
React.Fragment
is not an alternative for React.StrictMode
🙂
@iamandrewluca CMIIW the problem comes from react-transition-groups (as you said). Reactstrap is using that library at version 2.9.0. But last version is 4.4.1. Would it still happen in a more recent version? What's blocking reactstrap from updating?
My guess is that the author wants to support React < 16.3 which has no the new Context API. But react-transition-groups@3
requires the new Context API
We don't have time to allocate for this. And because this will be a breaking change, we thought of making multiple breaking changes at a time. But for that we have to allocate a lot of time, which we don't have.
Yes, I found this warning as well, if you boys have any suggestions please step up and suggest. Thanks!
Same problem I'm facing when using Collapse from reactstrap. Is there any solution? Thanks
Has this issue really been on for more than two years? I keep getting an error when using the Carousel
component
İndex.js değişikliklerinde
React.StrictMode
içinReact.Fragment
@@
thankx :)
React.Fragment
if you are beginner you can use it temporily :)
Deleting "
But since I'm newbie to React, I'm not sure how the right step is
İndex.js dosyasında "
" i silmek de etkili olabilir. Bunu çözmek için bu şekilde kullanmayı seçtim; "ReactDOM.render (, document.getElementById ('root'));" Ama React için acemi olduğum için doğru adımın nasıl olduğundan emin değilim
selamlar , direkt olarak bütün dosyalar için fragment verilmesi en mantıklısı. İhtimale dayalı bir kod aslında. Araştırdım biraz
@iamandrewluca Can the removal of the legacy APIs be part of the 9.0 release?
This issue still are going on ? Isn't unsafe and dangerous to disable StrictMode ?
@sbaechler , @Allakazan yes we have an opportunity now with the upcoming 9.x release.
However FYI there are no full time maintainers so any PRs for this off bootstrap5 branch would be appreciated.
(A few of us are helping out to get Reactstrap 9.x Bootstrap 5.x stable and released.)
I've updated rtg to v4 in linked PR, but need to test if addresses everything in this issue. I don't see direct usages of old context API, but catching up here..
Carousel looks like still uses legacy context, but the RTG bump will help in most cases. If Carousel can be updated easily before 9.x release we can do it, but seems could also be a point fix after that too. PRs are welcome: https://github.com/reactstrap/reactstrap/blob/master/src/Carousel.js#L27
Also updated Carousel context issue in #2268 We'll do another pre release this week for you all to try out.
TabPane
,Dropdown(,Item,Menu,Toggle)
,Manager
,PopperTargetHelper
,CarousellItem
(see https://github.com/reactstrap/reactstrap/search?q=contextTypes&unscoped_q=contextTypes)6.5.0
es
16.7.0
4.2.1
What is happening?
When using
<React.StrictMode>
Reacts advises against using the legacy context API:What should be happening?
Reactstrap should be using the new Context API.
Steps to reproduce issue
Wrap an example app using some of the components mentions at the beginning in
React.StrictMode
and start it in development mode.Code
https://stackblitz.com/edit/reactstrap-saxswj?file=Example.js