search

reactwg / react-native-releases

React Native Releases Working Group
358 stars 7 forks source link

[0.76] Fix init behavior for 0.76 #508

Open cortinico opened 1 month ago

cortinico commented 1 month ago

Target Branch(es)

0.76

Link to commit or PR to be picked

https://github.com/facebook/react-native/pull/46560

Description

This fixes the init behavior for 0.76

huntie commented 1 month ago

@cortinico @blakef I still can't see working E2E behaviour with react-native@0.76.0-rc.2. Also, we should print "No changes made." or similar in the code branch where a noop happens — looks like https://github.com/facebook/react-native/pull/46547 was clobbered by https://github.com/facebook/react-native/pull/46560.

Let's push for some polish here 🙏🏻

image
blakef commented 1 month ago

~@huntie weren't your changes meant to resolve this issue? I'm not sure what you mean by clobbered?~ This isn't going to work. We've removed @react-native-community/cli as a dependency from react-native. So you can't run it this way from npx.

The message isn't actually accurate either. we're don't run npx @react-native-community/cli init we run require('@react-naive-community/cli').run(args). I'll put up another change that'll have to land with RC3.