search

readbeyond / aeneas

aeneas is a Python/C library and a set of tools to automagically synchronize audio and text (aka forced alignment)
http://www.readbeyond.it/aeneas/
GNU Affero General Public License v3.0
2.49k stars 228 forks source link

numpy as setup's requirement #177

Closed mgaitan closed 7 years ago

mgaitan commented 7 years ago

This PR patchs setup.py as proposed by #174.

readbeyond commented 7 years ago

Hi, thank you for taking time to provide a patch.

Please see my review comments, and also consider my last comment on the issue: https://github.com/readbeyond/aeneas/issues/174#issuecomment-301236666

(Also, next time, to avoid you wasting time, please let me know that you are going to provide a PR --- I coded it already on my machine to test your suggestion...)

pettarin commented 7 years ago

@mgaitan Given the difficulties in creating a wheel that works on any linux, I think this PR can be revitalized. If you have time to fix the minor issues I reviewed above, I will merge on devel (and let people test). If not, just let me know, I will work them out. In any case, I will credit you in the ack section of the README.

mgaitan commented 7 years ago

@pettarin I've just updated as required. please let me know if something more to do.

readbeyond commented 7 years ago

@mgaitan Thank you. Merged. I will add you to the Acknowledgment section in a separate commit.

pettarin commented 7 years ago

Just an additional comment. On my cheap VPS:

$ pip install aeneas....tar.gz
# takes ~4 minutes

$ pip install numpy && pip install aeneas....tar.gz
# takes ~10 seconds

since installing numpy via its wheel is much faster than compiling its C parts from source.