search

readbeyond / aeneas

aeneas is a Python/C library and a set of tools to automagically synchronize audio and text (aka forced alignment)
http://www.readbeyond.it/aeneas/
GNU Affero General Public License v3.0
2.45k stars 218 forks source link

Add package for python3-aeneas #245

Closed StephenMcConnel closed 4 years ago

StephenMcConnel commented 4 years ago

Also fix spurious warning messages that occur for at least python 3.8.

This is needed for the soon arrival of Ubuntu 20.04 which ships with python3 by default.

chrisvire commented 4 years ago

@pettarin, could you accept this PR? We need this change for support Ubuntu Focal 20.04 which doesn't have Python2.

pettarin commented 4 years ago

Hi, things are tough here in Italy... I will try to have a look at the PR during the weekend.

On 5/6/20 8:51 PM, Chris Hubbard wrote:

@pettarin https://github.com/pettarin, could you accept this PR? We need this change for support Ubuntu Focal 20.04 which doesn't have Python2.

pettarin commented 4 years ago

@chrisvire @StephenMcConnel Hi, thanks a lot for taking care of the necessary changes. I will going to merge this PR as soon as you confirm it is ready on your side. alberto@readbeyond.it is good indeed.

Note that tomorrow (Sunday 2020-05-10) I will also update a bit the documentation, and include new languages, since eSpeak-ng now supports a lot more: https://github.com/espeak-ng/espeak-ng/blob/master/docs/languages.md

If I manage, I will try to release on PyPI by the end of next week --- say, Sunday 2020-05-17.

pettarin commented 4 years ago

@chrisvire @StephenMcConnel also, might I ask you to open the PR against the devel branch, i.o. directly master, please?

chrisvire commented 4 years ago

@pettarin: we can open another PR agains devel as well. We will likely want to have a published package using 1.7.3 and then have some time to test against 1.7.4.

Thanks, Chris

chrisvire commented 4 years ago

@pettarin: This looks all good to me. Can you merge it?

readbeyond commented 4 years ago

@chrisvire @StephenMcConnel Merged, thank you! I will credit you in the documentation, as of 1.7.4. (I planned to work towards 1.7.4 last Sunday, but I had to deal with an emergency and my plans went south. I hope the upcoming weekend will be easier on me.) I understand that you do not need a PyPI release, for the deb package the merge on master was sufficient, isn't it?