readchina / ReadAct

Worlds of Reading during China's long 1970s
https://readchina.github.io/readact
Creative Commons Attribution Share Alike 4.0 International
8 stars 8 forks source link

🐞 fix(PE): ajust type for PEs #513

Closed duncdrum closed 2 years ago

duncdrum commented 2 years ago

add agent_type to Agent schema and table

adjust schema and docs for work_ and space_type

ultimately the initial CI failure was my mistake, duh.

see #509 close #512

duncdrum commented 2 years ago

@whalekeykeeper This contains a fair number of Q-ids, however since Readactor hasn't run against the 2.0 branch, a few hundred agents from the person table are still missing. There might also be some institutions which we are now capturing which we haven't before. Once this is merged you should point redactor to the 2.0 branch, updated your local examples and tests where necessary, and do another run into a feature branch, that has 2.0 as its base.