search

readchina / ReadAct

Worlds of Reading during China's long 1970s
https://readchina.github.io/readact
Creative Commons Attribution Share Alike 4.0 International
8 stars 7 forks source link

Feature simplify GHA script #515

Closed duncdrum closed 2 years ago

duncdrum commented 2 years ago

there is now a repository GHA script https://repository.frictionlessdata.io

duncdrum commented 2 years ago

see https://repository.frictionlessdata.io/report/?user=readchina&repo=MWE-field-error&flow=ci&run=2911403832

and https://repository.frictionlessdata.io/report/?user=readchina&repo=MWE-field-error&flow=ci&run=2911423225

duncdrum commented 2 years ago

ok I like the badge and the fact that this safes us a couple of lines in the CI config. Yet, our CI is doing more than just run frictionless so we ll would need two badges.

I don't like the fact that the errors are not printed to the console on CI, instead users have to click a link, but there they then see a partial display of the erroneous CSV in pretty html format.

duncdrum commented 2 years ago

Why we're not doing it, the docker based workflow of the action script is slower than our current manual steps. lastly we would also commit two json files 'report' and 'inquiry' into the repo. Overall the lines we save in the Ci script aren't worth it imv.