404 on comics website

[duncdrum]

The URL mentioned here on Github, and the tile on the read china webpage result in a 404

[whalekeykeeper]

Hi Duncan, thanks for opening this issue! I have some questions about this issue.

1. Should this comics repository be public or private? I made it public earlier today (with asking Lena's permission) because I read "If do you want to use the submodule, make sure you use https:// when referencing the submodule (not http://) and that the submodule is in a public repository." But I googled for more and there are discussions about using private repository as submodule as long as it points to a public repository, and it is also illustrated in GitHub Docs : "You can only use submodules that point to public repositories, because the GitHub Pages server cannot access private repositories." Should I convert this repository back to private?

2. For this possible reason, I have two guesses. One is that the ReadChina's education status' change caused this and something should be re-set. In this case, I read the workflow file again but couldn't find any trace yet. The other is that, the submodule itself has some setting mistakes. For this guess, I deleted my local repository and used the command "git clone --recurse-submodules --remote-submodules https://github.com/readchina/comics.git" to re-clone it locally, there GitHub Desktop reminds me of "Submodule changes", see the following picture:

   

I have created a new branch but I am not sure if this is the reason. Therefore, I want to ask for suggestions, and, especially, in current case, how could I test with this hugo-book update if I don't want to mess the main branch up.

More additional questions are about the node12 to node16 warning (see #48 ):

3. Should I update actions/checkout@v2, actions/setup-node@v2, and actions/cache@v2 to their latest versions actions/checkout@v4, actions/setup-node@v4, and actions/cache@v3 ?

4. The readchina.github.io is using actions/checkout@v3 but it's v2 in this repo, could this be the potential issue for the submodule problem?

Thanks for all the help.

[duncdrum]

Hi @whalekeykeeper,

1. public makes sense after project end, however it makes contents freely downloadable.
2. If you update the sub module in a feature branch and make a local build you should see potentially breaking changes.
3. yes, please update all GitHub action workflow components. You can also add a dependabot.yml to prep the repo for maintenance mode.
4. See 3. It’s possible that this is the problem.

[whalekeykeeper]

Hi @duncdrum , thanks! For the 2nd point, the local build of the comics' site was working in the past months. But yeah, I will go to update now and compare what is changed. And is there a way to see if comics' site be available on readchina.github.io before I commit, push, open a new PR and the PR is pushed? And should the changes which was shown in the picture in the last comment be kept? I have clicked the open repository on GitHub Desktop

and then I have a local repo which is .../comics/themes/hugo-book, I ran hugo server -D there and I got (upper part is the terminal screenshot if I run hugo server -D with the comics repository which is also .../comics/themes/hugo-book when I copy the path on GitHub Desktop, lower part is the terminal screenshot if I run the same command with the new hugo-book local repo:

Plus, for 4th point, should I update the actions/checkout@v3 at readchina.github.io into actions/checkout@v4 as well?

[whalekeykeeper]

And there are changes after running hugo server -D

in the repository .

Once I switch back to the "normal" comics' repository

I get this warning which says This submodule change cannot be added into a commit in this repository because it contains changes that have not been commited.

[duncdrum]

You have untracked changes for the Alex-shpak/Hugo-book repo from building it, simply discard in that repo, and then go back to the comics repo and commit and changes there.

please check the readme, we need to see if the feature/prev-next branch still exist, or if these changes are now on main if they are on main all the better.

worst case delete everything and start out fresh.

And yes updating all aha scripts to their latest versions would be a good idea, + adding the dependabot.yml so we get automated update PRs

[whalekeykeeper]

Thank you!

You have untracked changes for the Alex-shpak/Hugo-book repo from building it, simply discard in that repo, and then go back to the comics repo and commit and changes there.

Done

please check the readme, we need to see if the feature/prev-next branch still exist, or if these changes are now on main if they are on main all the better.

The feature/prev-next branch still exists

worst case delete everything and start out fresh.

And yes updating all aha scripts to their latest versions would be a good idea, + adding the dependabot.yml so we get automated update PRs

Updated and opened PRs for dependabot.yml for both readchina.github.io and comics

[whalekeykeeper]

Hi @duncdrum , the pages build and deployment already ran without problems, and the site looks fine during local building as well. However, the readchina.github.io/comics is still getting 404 File not found error. I found GitHub Docs said Switching the repository's visibility from public to private or vice versa will change the URL of your GitHub Pages site, which will result in broken links until the site is rebuilt. Do you know what exact the rebuilt means? I am thinking it might be the reason that the comics site is still missing.

[whalekeykeeper]

Also, the dependabot opened some new PRs, they looks fine for me, shall I approve and merge them?

[duncdrum]

I have no idea why we still get a 404 but it's very likely related to the URL change when we made the repo public. The URL is also configured in config.toml local builds look indeed fine.

You can reach out to GitHub support and see if they have any ideas why this isn't working anymore

[whalekeykeeper]

I have no idea why we still get a 404 but it's very likely related to the URL change when we made the repo public. The URL is also configured in config.toml local builds look indeed fine.

You can reach out to GitHub support and see if they have any ideas why this isn't working anymore

Thanks! I will go to ask.