reading-am / reading

The dreams! The dreams! It's all just absurdity in the light of day but the dreams!
MIT License
10 stars 0 forks source link

Add in-browser notifications of @mentions #332

Open leppert opened 12 years ago

leppert commented 12 years ago

@sjkaliski have you managed to get up and running? I know @davidbyrd11 has been ploughing through it.

thebyrd commented 12 years ago

I'm helping him right now. RVM is down so we're trying to install the right version of ruby without it On Nov 13, 2012, at 10:06 PM, Greg Leppert notifications@github.com wrote:

@sjkaliski have you managed to get up and running? I know @davidbyrd11 has been ploughing through it.

— Reply to this email directly or view it on GitHub.

leppert commented 12 years ago

Be wary of the missing Readability Content API token. I'm working on getting one for dev so we don't have to pass around the production token but until I do you'll get an error on the Page#populate_readability after_create callback (page.rb line 12). This is called during Post#create when you're posting from a page that hasn't been posted from previously.

On Nov 13, 2012, at 10:07 PM, David Byrd notifications@github.com wrote:

I'm helping him right now. RVM is down so we're trying to install the right version of ruby without it On Nov 13, 2012, at 10:06 PM, Greg Leppert notifications@github.com wrote:

@sjkaliski have you managed to get up and running? I know @davidbyrd11 has been ploughing through it.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

sjkaliski commented 12 years ago

Wrapping set up now. I also want this to include changing the page title (just like gmail and facebook) when someone responds. @davidbyrd11 and I were just talking on a page, and I left and had no idea he replied.

sjkaliski commented 11 years ago

http://cl.ly/image/0C2S1q3u3t25

So I wanted the notification to be really light. And only link you to one place, the site the user is on. No profile, no image, nothing. Also, rather than "on a site" have a portion of the page title (although I wouldn't want the notification to become too large, or have an ellipsis...)

Thoughts?

leppert commented 11 years ago

I think that's a great idea. Let's put it in and test it; we can mention the hell out of each other and see how it feels.

On Dec 2, 2012, at 11:07 PM, Steve Kaliski notifications@github.com wrote:

http://cl.ly/image/0C2S1q3u3t25

So I wanted the notification to be really light. And only link you to one place, the site the user is on. No profile, no image, nothing. Also, rather than "on a site" have a portion of the page title (although I wouldn't want the notification to become too large, or have an ellipsis...)

Thoughts?

— Reply to this email directly or view it on GitHub.

sjkaliski commented 11 years ago

I'm going to take another day to clean it up (a couple hacky things I want to drop), and then let's put it in

leppert commented 11 years ago

Look forward to seeing it!

On Dec 3, 2012, at 8:40 PM, Steve Kaliski notifications@github.com wrote:

I'm going to take another day to clean it up (a couple hacky things I want to drop), and then let's put it in

— Reply to this email directly or view it on GitHub.

thebyrd commented 11 years ago

Notifications are coming along (https://github.com/leppert/reading/tree/332-notifications). What options should we give people for receiving notifications? Here are some that I thought of: