readium / SDKLauncher-iOS

A small iOS application to serve as a launcher/testbed for the Readium SDK.
BSD 3-Clause "New" or "Revised" License
71 stars 47 forks source link

iOS 9 App Transport Security: change to localhost and whitelist in plist #65

Closed msintov closed 8 years ago

msintov commented 8 years ago

iOS 9 App Transport Security doesn't allow http requests by default. Added "localhost" to the whitelisted list of domains in the plist. Also changed "127.0.0.1" to "locallhost" in EPubViewController.m for iOS 9 and above only. Tested that in airplane mode with Wi-Fi off on iOS 9, media overlays, audio and video still play.

danielweck commented 8 years ago

Thank you @msintov Some general remarks to keep track of: See discussion thread in https://github.com/readium/SDKLauncher-iOS/pull/64 (Bluefire's original proposed fix) Note the comments about airplane mode (no wifi / network connectivity) and the implications with regards to locahost vs. 127.0.0.1

danielweck commented 8 years ago

@msintov Sorry to be a pain, but Pull Requests must be for the develop branch, not master. Could you please adjust accordingly? Thanks :)

danielweck commented 8 years ago

Using PR https://github.com/readium/SDKLauncher-iOS/pull/64