search

readium / SDKLauncher-iOS

A small iOS application to serve as a launcher/testbed for the Readium SDK.
BSD 3-Clause "New" or "Revised" License
71 stars 47 forks source link

RDContainer.mm/h are attached which are detached from the Readium SDK project. #66

Closed drminside closed 8 years ago

drminside commented 8 years ago

Dear Readium SDK people.

I send a pull request for update SDKLauncher-ios. This is to include unchanged RDContainer.mm/h files which are detached from the Readium SDK project.

The reason why those files are attached SDKLauncher-iOS rather than Readium SDK is:

  1. Since RDContainer.mm needs to be modified to include LCP related header file and initialization code int the future, it is better to be in the SDKLauncher-iOS side in order to make Readium-SDK a DRM agnostic library.
  2. In Launcher-OSX case, the initialization process including ePub3::InitializeSdk() is in the LauncherOSX/LOXePubSdkApi.mm file, not in the Readium SDK, which is pretty natural.

The merge should be done together with disposal of the pull request of the Readium SDK. Because only one disposal of either SDKLauncher-iOS or Readium SDK could make duplication or missing files problem.

And for the consistency of the Readium codes, in the future, we recommend all Launcher related files should locate at Launcher project instead of Readium SDK like Launcher-OSX case.

danielweck commented 8 years ago

Superseded: https://github.com/readium/readium-sdk/pull/216