search

readium / SDKLauncher-iOS

A small iOS application to serve as a launcher/testbed for the Readium SDK.
BSD 3-Clause "New" or "Revised" License
71 stars 47 forks source link

Pull request to update for supporting LCP #68

Open drminside opened 8 years ago

drminside commented 8 years ago

Dear Readium SDK people.

I send a pull request for SDKLanucher-iOS for supporting LCP.

Following are summary for changed files:

  1. Classes/ContainerController.m We added 'drmInitialize.h' file for DRM initialization. And we also added containerRegisterContentModules to invoke Drminitialize, which is currently disabled by definition FALSE. Because if it is in the compiled code, link error will be occurred due to no LCP library. So if user wants to include the DRM feature into the Launcher, he has to make READIUM_DRM definition as TRUE and include the Readium DRM submodule into the Launcher project,
  2. Classes/ContainerListController.m We have changed the way of opening EPUB by processing in separate thread. Because LCP needs to popup pass-phrase dialog-box waiting user input in the Readium SDK, which does not work in the same thread.
  3. Classes/drmInitialize.h It is added for drmInitialize() prototype whose .m code is in Readium DRM submodule
  4. SDKLauncher-iOS.xcodeproj/project.pbxproj Project has changed to add classes/drmIntialize.h file

This pull request does not include Readium DRM submodule, which is necessary to activate DrmInitialize() in change 1.

I think this is one of the best ways to maintain DRM feature separately against Launcher and not to shake existing project structure much.

If anyone has a better idea, please suggest us.

rkwright commented 8 years ago

Need to figure out how this folds into the ongoing work to integrate LCP with Readium.