search

readium / go-toolkit

A toolkit for ebooks, audiobooks and comics written in Go
https://readium.org/web
BSD 3-Clause "New" or "Revised" License
37 stars 14 forks source link

Multilingual string (metadata), lower case #34

Closed danielweck closed 5 months ago

danielweck commented 7 years ago

https://github.com/readium/r2-streamer-go/blob/master/parser/epub.go#L214

            contributor.Name.MultiString = make(map[string]string)
            contributor.Name.MultiString[publication.Metadata.Language[0]] = cont.Data

            for _, m := range metaAlt {
                contributor.Name.MultiString[m.Lang] = m.Data
            }

...should lower-case the language code, to be consistent with:

https://github.com/readium/r2-streamer-go/blob/master/parser/epub.go#L280

            publication.Metadata.Title.MultiString = make(map[string]string)
            publication.Metadata.Title.MultiString[strings.ToLower(mainTitle.Lang)] = mainTitle.Data

            for _, m := range metaAlt {
                publication.Metadata.Title.MultiString[strings.ToLower(m.Lang)] = m.Data
            }
danielweck commented 7 years ago

Re-opening, see: https://github.com/readium/r2-streamer-go/commit/fdca13ab734189e0b580309d6c502549eadbcf54#commitcomment-21630363