R2BasicWebView.Listener#resourceAtUrl should probably have a default value

readium / kotlin-toolkit

A toolkit for ebooks, audiobooks and comics written in Kotlin

https://readium.org/kotlin-toolkit

BSD 3-Clause "New" or "Revised" License

186 stars 82 forks source link

R2BasicWebView.Listener#resourceAtUrl should probably have a default value #312

Closed sdsantos closed 1 year ago

sdsantos commented 1 year ago

Testing out the latest version at develop and noticed a small thing that was probably missed. The method resourceAtUrl at R2BasicWebView.Listener should probably have a default value null like the other new methods tagged with @InternalReadiumApi.

mickael-menu commented 1 year ago

Good point, I fixed it in https://github.com/readium/kotlin-toolkit/pull/305