search

readium / kotlin-toolkit

A toolkit for ebooks, audiobooks and comics written in Kotlin
https://readium.org/kotlin-toolkit
BSD 3-Clause "New" or "Revised" License
172 stars 74 forks source link

Epub onTap "freeze" on device rotation #360

Closed LubomirGanchev closed 1 year ago

LubomirGanchev commented 1 year ago

Bug Report

What happened?

When device is rotated in landscape for example, the onTap functionality seems to stop working. It doesn't seems to fix itself after rotating the device back to the original orientation. As I said in slack it happens on certain devices/models. For example it never happened on my personal OnePlus Nord (android 12). I am attaching a video captured on emulator using the readium test app.

Expected behavior

How to reproduce?

Open the test app and load a book (in this example i used Le Mystere from the OPDS Test catalog). Once the book is loaded rotate the device orientation and tap in the middle or the sides.

https://github.com/readium/kotlin-toolkit/assets/109721963/7be1ed47-05fa-4b39-b99e-c5c4eca550fb

Environment

Development environment

Testing device

Additional context

mickael-menu commented 1 year ago

@LubomirGanchev Let me know if this helps: https://github.com/readium/kotlin-toolkit/pull/361

LubomirGanchev commented 1 year ago

Hi Michael, sorry for the late answer, but this change seems to fix the problem!