search

readium / lcp-specs

🔐 Releases, drafts and schema for Readium LCP
https://readium.org/lcp-specs/
BSD 3-Clause "New" or "Revised" License
10 stars 5 forks source link

Typo in JSON Schema: revoke vs. revoked #31

Closed danielweck closed 5 years ago

danielweck commented 5 years ago

https://github.com/readium/lcp-specs/blob/5828f83b6fffee23cbc38870f6f6431744191f21/schema/status.schema.json#L75

LSD event revoked should be revoke.

Spec. reference: https://github.com/readium/lcp-specs/blob/master/lsd.md#27-events

mickael-menu-mantano commented 5 years ago

I just fixed the Swift parser to use revoked instead of revoke, using the JSON schema... 🙃

HadrienGardeur commented 5 years ago

This feels more like a typo in the spec IMO.

llemeurfr commented 5 years ago

I disagree. The spec is ok, we have chosen to use active terms in events, passive in status.

HadrienGardeur commented 5 years ago

Yeah... I just looked back at the rest of the value and it is indeed consistent with the rest of it.