readium / r2-navigator-js

NodeJS Readium2 "navigator"
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Paginated mode blocks reading a book on Windows at least #45

Open manuellagrand opened 5 years ago

manuellagrand commented 5 years ago

reading is blocked after few pages in paginated mode (approximatively 2 pages) depending on the os that is used. with MacOS and Ubuntu 16.04 no problem, but on Windows 10 and Ubuntu 18.04 the reader doesn't work like it should.

danielweck commented 5 years ago

What is the exact source / build of the app (develop branch, or prebuilt installer?) I need to see/check the precise navigator version in package-lock.json to make sure the Electron/Chromium fix for left-right arrow keys is included.

manuellagrand commented 5 years ago

the source is develop branch and navigator version is 1.0.26

panaC commented 5 years ago

Hello,

I think this issue is related to a second display glitch

On reader :

image

When I lower the height of the window, then I raise it to the same height as before.

image

image

That display the previous "page" of book and not the same.

I think we can lost the postion in book.

What do you think ?


Ubuntu lts 18.04 r2-navigator in 1.0.26

llemeurfr commented 5 years ago

To narrow down the problem, is there some log we could add to the software, so we can check something?

danielweck commented 5 years ago

I am not able to reproduce this on Windows 10.

danielweck commented 5 years ago

PS: I am using the develop branch (well, this actually: https://github.com/readium/readium-desktop/pull/323 )

manuellagrand commented 5 years ago

the paginated mode issue seems fixed on Windows 10. Now, it's the scrollable mode on Windows 10 that blocked book reading. I am using the develop branch

panaC commented 5 years ago

On ubuntu lts 18, it's opposite of the Manuel answer.

Paginated mode is blocked at each new chapter whereas it doesn't blocked in scrollable mode

danielweck commented 5 years ago

I cannot reproduce (scroll or paginated) on Linux (Lubuntu 18.04)

danielweck commented 5 years ago

I test with various EPUBs, usual suspects: Wasteland, AccessibleEPUB3, ChildrensLitterature ... What EPUBs are problematic in your tests?

danielweck commented 5 years ago

Regarding "loosing the reading location": yes, this is a problem we had in Readium1 as well. Because we track the upper-left corner of the document text in order to estimate the user's reading position, when the window is resized there is a side effect of "walking backwards". Note that we also track the reading location when the user interacts with the mouse or keyboard in the document, but this isn't related.

danielweck commented 5 years ago

I posted a separate issue: https://github.com/readium/r2-navigator-js/issues/43

panaC commented 5 years ago

I used this epub: https://bibliothequenumerique.tv5monde.com/download/epub/470

manuellagrand commented 5 years ago

in my case i used this epub: https://github.com/IDPF/epub3-samples/releases/download/20170606/moby-dick.epub

danielweck commented 5 years ago

https://bibliothequenumerique.tv5monde.com/download/epub/470 => 504 Gateway Time-out - nginx

panaC commented 5 years ago

daniel.tar.gz

danielweck commented 5 years ago

Dumas - Le Comte de Monte Cristo-37.epub => works fine too in my tests (scroll and paginated)

panaC commented 5 years ago

It's works now. I just removed and added the epub. Sorry for the inconvenience

danielweck commented 5 years ago

No problems. Weird though!

danielweck commented 5 years ago

On MacOS I have observed a pagination bug (CSS Columns) which sounds very similar to this! When I shring the window to a smaller size, there comes a threshold point at which the reported number of columns/spreads is completely wrong (usually a very small number). It is easy to see in debug/development mode (npm run start:dev) thanks to the verbose console messages coming from the navigator (Locator notifications). Very strange bug. I suspect this is a weird edge case with Chromium-in-Electron (not the first one, not the last one ... :( )

panaC commented 5 years ago

Sorry but finally I still have this issue. The behavior is very strange on all epub that I check. (include le comte de monte cristo). When i click on the arrow in reader. inevitably it hangs