search

readium / r2-shared-js

Shared models for Readium Desktop
BSD 3-Clause "New" or "Revised" License
11 stars 13 forks source link

MARC relator Inker Penciller Letterer, parser uses non-standard codes #17

Open danielweck opened 5 years ago

danielweck commented 5 years ago

See description of the problem here: https://github.com/readium/webpub-manifest/issues/26#issuecomment-479408571

danielweck commented 5 years ago

Letterer: https://github.com/readium/r2-shared-js/blob/096a56aa96a030e4f11a4809d9577ab06cfd19ce/src/parser/epub.ts#L1047-L1053

danielweck commented 5 years ago

Penciller: https://github.com/readium/r2-shared-js/blob/096a56aa96a030e4f11a4809d9577ab06cfd19ce/src/parser/epub.ts#L1054-L1060

danielweck commented 5 years ago

Inker: https://github.com/readium/r2-shared-js/blob/096a56aa96a030e4f11a4809d9577ab06cfd19ce/src/parser/epub.ts#L1068-L1074

danielweck commented 5 years ago

Commenting the above 3 code blocks will result in defaulting to a generic Contributor + Role (for example if the WebPub code letterer is used in the source publication): https://github.com/readium/r2-shared-js/blob/096a56aa96a030e4f11a4809d9577ab06cfd19ce/src/parser/epub.ts#L1089-L1096

...However this also means that Metadata.Inker|Penciler|Letterer will never be populated.