readium / r2-shared-js

Shared models for Readium Desktop
BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

dc:source and dc:rights not in RWPM JSON Schema / JSON-LD context, not in EPUB parsing rules #26

Open danielweck opened 3 years ago

danielweck commented 3 years ago

See: https://github.com/readium/webpub-manifest/issues/66#issuecomment-673000958

This code should be disabled (this will trigger the AdditionalJSON property and dc:source will be preserved "as is"):

https://github.com/readium/r2-shared-js/blob/1aa1a1c10fe56ccb99ef0ed2c15a198c46600e7a/src/models/metadata.ts#L447-L451

https://github.com/readium/r2-shared-js/blob/1aa1a1c10fe56ccb99ef0ed2c15a198c46600e7a/src/models/metadata.ts#L436-L440

https://github.com/readium/r2-shared-js/blob/1aa1a1c10fe56ccb99ef0ed2c15a198c46600e7a/src/parser/epub.ts#L485-L487

This code remains:

https://github.com/readium/r2-shared-js/blob/1aa1a1c10fe56ccb99ef0ed2c15a198c46600e7a/src/parser/epub/opf-metadata.ts#L74-L76