search

readium / r2-shared-js

Shared models for Readium Desktop
BSD 3-Clause "New" or "Revised" License
11 stars 12 forks source link

sort_as, belong_to rename to camelCase (JSON properties) #7

Closed danielweck closed 5 years ago

danielweck commented 5 years ago

https://github.com/readium/r2-shared-js/blob/44ebead56f6a4e0575c384ddf55cf42c8527f6d6/src/models/metadata.ts#L128

https://github.com/readium/webpub-manifest/blob/master/schema/metadata.schema.json#L140

danielweck commented 5 years ago

Missing in: https://github.com/readium/r2-shared-js/blob/develop/src/models/metadata.ts#L128

Here: https://github.com/readium/r2-shared-js/blob/44ebead56f6a4e0575c384ddf55cf42c8527f6d6/src/models/metadata-collection.ts#L21

https://github.com/readium/webpub-manifest/blob/ffb350ca09c85d5f15cb4ae0453bd0b3dcb15440/schema/metadata.schema.json#L78

danielweck commented 5 years ago

Done, with bidirectional (de)serialization fallback mechanism which favours the new names as output whilst supporting the legacy names as input.