TypeError with publications in Readium 1

readium / r2-streamer-js

NodeJS Readium2 "streamer"

BSD 3-Clause "New" or "Revised" License

21 stars 10 forks source link

TypeError with publications in Readium 1 #25

Closed JayPanoz closed 6 years ago

JayPanoz commented 6 years ago

FYI Readium 1 is failing with all 3 publications on demo server.

Example url

Console error:

TypeError: undefined is not an object (evaluating 'webpubJson.metadata.publisher[0]') → getMetadata (package_document_parser.js:41)

So that’s

// getElemText(metadataElem, "publisher");
metadata.publisher = webpubJson.metadata.publisher[0].name;

danielweck commented 6 years ago

Thanks Jiminy! I am closing this issue as this is not a problem with r2-streamer-js.

I actually reported about this a little over a year ago :) https://github.com/readium/readium-js/pull/180#issuecomment-316779856

Problem: there are missing sanity checks in EvidentPoint's prototype implementation (which is a modification of Readium1's parser to convert Readium2's "webpub manifest" format into the internal data structure used by ReadiumJS).

CC @barbender