search

readium / r2-testapp-js

NodeJS Readium2 "test app"
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Linux: Debian package works (unlike AppImage), but no top-level menu unless reader view open #18

Closed danielweck closed 5 years ago

danielweck commented 5 years ago

This in itself is not a big deal, but what is more annoying is that the small "open publication" dialog does not have a "exit" option, so it requires CTRL-C to shutdown!!

1) Download r2-testapp-js_1.0.6-0_amd64.deb from https://github.com/readium/r2-testapp-js/releases/tag/latest-linux 2) sudo apt-get install ./r2-testapp-js_1.0.6-0_amd64.deb 3) r2-testapp-js

danielweck commented 5 years ago

Related issue: https://github.com/readium/r2-testapp-js/issues/17

danielweck commented 5 years ago

Same problem in Windows.

danielweck commented 5 years ago

Fixed by adding the missing top-level menu, and more importantly by adding a confirmation dialog to exit the app (same logic on MacOS, Linux and Windows to make things simple, although conventionally there is a different behaviour on MacOS because of the persistent window-less top-level menu ... but this is fine for a test app) https://github.com/readium/r2-testapp-js/commit/55a341d1f922674e4d11a655474f29ce3c23029b