about horizontal scroll issue

readium / r2-testapp-kotlin

BSD 3-Clause "New" or "Revised" License

134 stars 38 forks source link

about horizontal scroll issue #2

Closed hellcan closed 6 years ago

hellcan commented 6 years ago

I met this problem.

When I am try to slide to the next page. The page is over slide and can not stop at the right place. So how can I fix it?

issue

llemeurfr commented 6 years ago

Wahoo, you're the first external tester of this work in progress. We decided that it would be good to expose this alpha version for bringing together a community of Android developers around this Readium-2 architectured reading system. I hope you'll be one member of this community. Even if the fundamentals are good, this dev is far from being finished.

The snap points on Android are not as easy to implement as in iOS. @aferditamuriqi is working on it, ideas are welcome.

HadrienGardeur commented 6 years ago

@hellcan do you also experience this same issue when tapping instead of swiping?

HadrienGardeur commented 6 years ago

Basically, I think (correct me if I'm wrong @aferditamuriqi) that this is how swipe works currently:

the current webview is fully scrollable, which means that if you swipe quickly you could go beyond the next page
once you've stopped swiping, it attempts to snap the view to the closest page (using total width of the document divided by the width of the device)

Ideally we want a slightly different behaviour:

swiping shouldn't go beyond the next page
snapping should be smooth (animation) instead of a jump to the next snap point

hellcan commented 6 years ago

issue2

Thank you for response. This is how the tapping looks like. If the first page is not over slide, the next one works totally fine.

HadrienGardeur commented 6 years ago

It's worth pointing out that this is entirely handled in JS using https://github.com/readium/r2-testapp-kotlin/blob/master/r2-testapp/src/main/assets/ReadiumCSS/utils.js

We plan on having calls between the teams working with native (Swift, Kotlin) code and our JS developers in early 2018 to figure out a good strategy for cross platforms touch handling.

hellcan commented 6 years ago

Hello, I used Chrome remote debug tool today, and find out snap( ) missing in utils.js, which caused page was over sliding?

And I want start a personal app with Readium to help my job search. Is it necessary to switch to Readium2? And if you have estimate time for early 2018? Thank you