search

readium / r2-testapp-swift

BSD 3-Clause "New" or "Revised" License
146 stars 38 forks source link

Review build warnings #302

Closed aferditamuriqi closed 4 years ago

aferditamuriqi commented 4 years ago

/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationInfoViewController.swift:55:35: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use Result based callback instead. imageView!.kf.setImage(with: coverURL, ^ /Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPlaceholderView.swift:58:35: warning: 'ImageView' is deprecated: Use KFCrossPlatformImageView instead. public func add(to imageView: ImageView) { ^ /Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:131:13: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions switch deviceOrientation { ^ /Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:131:13: note: handle unknown values using "@unknown default" switch deviceOrientation { ^ /Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:141:13: warning: variable 'layoutNumberPerRow' was never mutated; consider changing to 'let' constant var layoutNumberPerRow:[UIUserInterfaceIdiom:[GeneralScreenOrientation: Int]] = [


        let
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:401:45: warning: 'index(where:)' is deprecated: renamed to 'firstIndex(where:)'
            guard let newIndex = self.books.index(where: { (element) -> Bool in
                                            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:401:45: note: use 'firstIndex(where:)' instead
            guard let newIndex = self.books.index(where: { (element) -> Bool in
                                            ^~~~~
                                            firstIndex
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:120:44: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use `Result` based callback instead.
                    cell.coverImageView.kf.setImage(with: coverURL,
                                           ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:183:17: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:183:17: note: handle unknown values using "@unknown default"
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Reader/Common/Bookmark/BookmarkDataSource.swift:33:35: warning: left side of nil coalescing operator '??' has non-optional type '[Bookmark]', so the right side is never used
            self.bookmarks = list ?? [Bookmark]()
                             ~~~~ ^~~~~~~~~~~~~~~

/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSRootTableViewController.swift:382:17: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSRootTableViewController.swift:382:17: note: handle unknown values using "@unknown default"
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:94:40: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use `Result` based callback instead.
                cell.coverImageView.kf.setImage(with: coverURL,
                                       ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:143:13: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:143:13: note: handle unknown values using "@unknown default"
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/App/AboutTableViewController.swift:53:34: warning: 'openURL' was deprecated in iOS 10.0
            UIApplication.shared.openURL(url)
                                 ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationInfoViewController.swift:55:35: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use `Result` based callback instead.
                    imageView!.kf.setImage(with: coverURL,
                                  ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPlaceholderView.swift:58:35: warning: 'ImageView' is deprecated: Use `KFCrossPlatformImageView` instead.
    public func add(to imageView: ImageView) {
                                  ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:131:13: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:131:13: note: handle unknown values using "@unknown default"
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:141:13: warning: variable 'layoutNumberPerRow' was never mutated; consider changing to 'let' constant
        var layoutNumberPerRow:[UIUserInterfaceIdiom:[GeneralScreenOrientation: Int]] = [
        ~~~ ^
        let
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:401:45: warning: 'index(where:)' is deprecated: renamed to 'firstIndex(where:)'
            guard let newIndex = self.books.index(where: { (element) -> Bool in
                                            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Library/LibraryViewController.swift:401:45: note: use 'firstIndex(where:)' instead
            guard let newIndex = self.books.index(where: { (element) -> Bool in
                                            ^~~~~
                                            firstIndex
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:120:44: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use `Result` based callback instead.
                    cell.coverImageView.kf.setImage(with: coverURL,
                                           ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:183:17: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSGroupTableViewCell.swift:183:17: note: handle unknown values using "@unknown default"
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/Reader/Common/Bookmark/BookmarkDataSource.swift:33:35: warning: left side of nil coalescing operator '??' has non-optional type '[Bookmark]', so the right side is never used
            self.bookmarks = list ?? [Bookmark]()
                             ~~~~ ^~~~~~~~~~~~~~~

/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSRootTableViewController.swift:382:17: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSRootTableViewController.swift:382:17: note: handle unknown values using "@unknown default"
                switch deviceOrientation {
                ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:94:40: warning: 'setImage(with:placeholder:options:progressBlock:completionHandler:)' is deprecated: Use `Result` based callback instead.
                cell.coverImageView.kf.setImage(with: coverURL,
                                       ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:143:13: warning: switch covers known cases, but 'UIDeviceOrientation' may have additional unknown values, possibly added in future versions
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/OPDS/OPDSPublicationTableViewCell.swift:143:13: note: handle unknown values using "@unknown default"
            switch deviceOrientation {
            ^
/Users/travis/build/readium/r2-testapp-swift/r2-testapp-swift/App/AboutTableViewController.swift:53:34: warning: 'openURL' was deprecated in iOS 10.0
            UIApplication.shared.openURL(url)
                                 ^
note: Using new build systemnote: Planning buildnote: Constructing build description